Skip to content

Update sql to prepare for sqlalchemy 2.0#71532

Merged
balloob merged 2 commits intohome-assistant:devfrom
bdraco:sql_20_prep
May 12, 2022
Merged

Update sql to prepare for sqlalchemy 2.0#71532
balloob merged 2 commits intohome-assistant:devfrom
bdraco:sql_20_prep

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 8, 2022

Proposed change

Update sql to prepare for sqlalchemy 2.0
https://docs.sqlalchemy.org/en/docs_preview/changelog/migration_20.html

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @dgomes, @gjohansson-ST, mind taking a look at this pull request as it has been labeled with an integration (sql) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@gjohansson-ST
Copy link
Copy Markdown
Member

Think you need it in the config flow as well

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 8, 2022

Think you need it in the config flow as well

Good call 👍

@bdraco bdraco marked this pull request as draft May 8, 2022 16:29
@bdraco bdraco marked this pull request as ready for review May 8, 2022 16:37
Copy link
Copy Markdown
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@balloob balloob merged commit 18bdc70 into home-assistant:dev May 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants